On Mon, Feb 28, 2022 at 6:02 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > On Mon, Feb 28, 2022 at 7:32 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using variable > > declaration inside of a for() loop. While the C99, C11 and later standards > > introduce many other features, most of these are already available in > > gnu89 as GNU extensions as well. > > > > An earlier attempt to do this when gcc-5 started defaulting to > > -std=gnu11 failed because at the time that caused warnings about > > designated initializers with older compilers. Now that gcc-5.1 is the > > minimum compiler version used for building kernels, that is no longer a > > concern. Similarly, the behavior of 'inline' functions changes between > > gnu89 and gnu11, but this was taken care of by defining 'inline' to > > include __attribute__((gnu_inline)) in order to allow building with > > clang a while ago. > > > > One minor issue that remains is an added gcc warning for shifts of > > negative integers when building with -Werror, which happens with the > > Is this a typo? > > building with -Werror, ... > -> > building with -Wextra, ... > I'm being slow today, Jani actually pointed out the same thing and I misunderstood him. Fixed it now, thanks! > Acked-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > > > Please let me know if you want me to pick up this. Yes, that would be great. I'll send a v3 with the updated changelog, but will drop most of the Cc list as there are no functional changes. Arnd _______________________________________________ greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx