Re: [PATCH] Staging: greybus: audio_codec: changed a void function to return 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hello Greg,

I've run the script on audio_code.c:
./scripts/ --file --terse drivers/staging/greybus/audio_codec.c

and got the following warning:
drivers/staging/greybus/audio_codec.c:1032: WARNING: void function return statements are not generally useful

As Brian wrote, we can either remove the return or leave it as is, so my "changes" can be ignored. This is not a coding style issue and I should have been more clear on the commit message. I apologize for the mistake.

Thank you and @Brian for taking the time to reply.

Kind regards,

Am 28.10.2021 18:42, schrieb Greg KH:
On Thu, Oct 28, 2021 at 05:38:08PM +0200, Senthu Sivarajah wrote:
From: Senthuran Sivarajah <ssivaraj@xxxxxxxxxxxxxxx>

Fixed a coding style issue.

What coding style exactly?

Signed-off-by: Senthuran Sivarajah <ssivaraj@xxxxxxxxxxxxxxx>

 drivers/staging/greybus/audio_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index b589cf6b1d03..9f99862791dc 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -1028,7 +1028,7 @@ static int gbcodec_probe(struct snd_soc_component *comp)
 static void gbcodec_remove(struct snd_soc_component *comp)
 	/* Empty function for now */
-	return;
+	return 0;

Did you build this change?

Exactly what tool reported a problem with this code and what was the
exact error?


greg k-h
greybus-dev mailing list

[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux