On Wednesday, August 25, 2021 3:45:13 PM CEST Alex Elder wrote: > On 8/25/21 12:20 AM, Fabio M. De Francesco wrote: > > On Monday, August 16, 2021 4:46:08 PM CEST Alex Elder wrote: > >> On 8/14/21 1:11 PM, Fabio M. De Francesco wrote: > >>> Convert greybus/uart.c from IDR to XArray. The abstract data type XArray > >>> is more memory-efficient, parallelisable, and cache friendly. It takes > >>> advantage of RCU to perform lookups without locking. Furthermore, IDR is > >>> deprecated because XArray has a better (cleaner and more consistent) API. > >> > >> I haven't verified the use of the new API (yet) but I have a few > >> comments on your patch, below. > >> > >> -Alex > > > > Dear Alex, > > > > On August 16th I submitted the v3 of my patch ("staging: greybus: Convert uart.c > > from IDR to XArray"), with changes based on the comments you provided. > > Yes, I intend to review version 3. I'm sorry I didn't respond to > your earlier message; I am on vacation this week. > > -Alex Oh, there's no hurry, sorry to bother you while on vacation. Even kernel hackers deserve a vacation at least once a year or two... :-) Thanks, Fabio > > > > Could you please take a few minutes to review this too? I would really appreciate it. > > > > The v3 patch is at https://lore.kernel.org/lkml/20210816195000.736-1-fmdefrancesco@xxxxxxxxx/ > > > > Thanks, > > > > Fabio > > > > P.S.: I'd also like to know if you think it's worth converting IDA to XArray in order > > to improve the Greybus driver in staging. > > > > > > > > > > _______________________________________________ > > greybus-dev mailing list > > greybus-dev@xxxxxxxxxxxxxxxx > > https://lists.linaro.org/mailman/listinfo/greybus-dev > > > > _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev