Hi "Fabio,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Fabio-M-De-Francesco/staging-greybus-Convert-uart-c-from-IDR-to-XArray/20210814-225807
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 0bd35146642bdc56f1b87d75f047b1c92bd2bd39
config: riscv-randconfig-r042-20210814 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 1f7b25ea76a925aca690da28de9d78db7ca99d0c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/901c5fde0540c767590bce646219889730c4a41b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Fabio-M-De-Francesco/staging-greybus-Convert-uart-c-from-IDR-to-XArray/20210814-225807
git checkout 901c5fde0540c767590bce646219889730c4a41b
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=riscv SHELL=/bin/bash drivers/staging/greybus/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> drivers/staging/greybus/uart.c:346:2: error: no member named 'xa_lock' in 'struct mutex'
xa_lock(&table_lock);
^~~~~~~~~~~~~~~~~~~~
include/linux/xarray.h:530:39: note: expanded from macro 'xa_lock'
#define xa_lock(xa) spin_lock(&(xa)->xa_lock)
~~~~ ^
drivers/staging/greybus/uart.c:358:2: error: no member named 'xa_lock' in 'struct mutex'
xa_unlock(&table_lock);
^~~~~~~~~~~~~~~~~~~~~~
include/linux/xarray.h:531:43: note: expanded from macro 'xa_unlock'
#define xa_unlock(xa) spin_unlock(&(xa)->xa_lock)
~~~~ ^
2 errors generated.
vim +346 drivers/staging/greybus/uart.c
341
342 static struct gb_tty *get_gb_by_minor(unsigned int minor)
343 {
344 struct gb_tty *gb_tty;
345
> 346 xa_lock(&table_lock);
347 gb_tty = xa_load(&tty_minors, minor);
348 if (gb_tty) {
349 mutex_lock(&gb_tty->mutex);
350 if (gb_tty->disconnected) {
351 mutex_unlock(&gb_tty->mutex);
352 gb_tty = NULL;
353 } else {
354 tty_port_get(&gb_tty->port);
355 mutex_unlock(&gb_tty->mutex);
356 }
357 }
358 xa_unlock(&table_lock);
359 return gb_tty;
360 }
361
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|