On Wed, May 26, 2021 at 09:50:55AM +0800, Tian Tao wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
> ---
> drivers/greybus/core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c
> index e546c64..434aa5d 100644
> --- a/drivers/greybus/core.c
> +++ b/drivers/greybus/core.c
> @@ -174,11 +174,9 @@ static int greybus_probe(struct device *dev)
> if (!id)
> return -ENODEV;
>
> - retval = pm_runtime_get_sync(&bundle->intf->dev);
> - if (retval < 0) {
> - pm_runtime_put_noidle(&bundle->intf->dev);
> + retval = pm_runtime_resume_and_get(&bundle->intf->dev);
> + if (retval < 0)
> return retval;
> - }
This code is correct and does not need changing.
The current API is not deprecated in any way and is in arguably more
consistently named than this new helper.
Feel free to use the new helper in your own code or suggest using it
when fixing drivers that didn't use pm_runtime_get_sync() correctly.
>
> retval = gb_control_bundle_activate(bundle->intf->control, bundle->id);
> if (retval) {
NAK.
Johan
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev
|