On 3/26/21 10:22 AM, Rasmus Villemoes wrote:
Including a nul byte in the otherwise human-readable ascii output from this debugfs file is probably not intended.
Looking only at the comments above simple_read_from_buffer(), the last argument is the size of the buffer (tmp_buf in this case). So "3" is proper. But looking at callers, it seems that the trailing NUL is often excluded this way. I don't really have a problem with your patch, but could you explain why having the NUL byte included is an actual problem? A short statement about that would provide better context than just "probably not intended." Thanks. -Alex
Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> --- drivers/greybus/es2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index 48ad154df3a7..86a7fbc7fe13 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -1171,7 +1171,7 @@ static ssize_t apb_log_enable_read(struct file *f, char __user *buf, char tmp_buf[3];sprintf(tmp_buf, "%d\n", enable);- return simple_read_from_buffer(buf, count, ppos, tmp_buf, 3); + return simple_read_from_buffer(buf, count, ppos, tmp_buf, 2); }static ssize_t apb_log_enable_write(struct file *f, const char __user *buf,
_______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|