On 2/15/21 10:11 PM, Du Cheng wrote:
> Wrap the multi-line definition inside a do {} while(0) block, in
> compliance to scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng <ducheng2@xxxxxxxxx>
No.
Please look at recent traffic on this mailing list.
And please look at the code you are changing, and
build the changed code (at least) before sending
a patch to the list.
-Alex
> ---
> drivers/staging/greybus/loopback.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index 2471448ba42a..9ae154908ec6 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \
> static DEVICE_ATTR_RO(name##_avg)
>
> #define gb_loopback_stats_attrs(field) \
> +do { \
> gb_loopback_ro_stats_attr(field, min, u); \
> gb_loopback_ro_stats_attr(field, max, u); \
> - gb_loopback_ro_avg_attr(field)
> + gb_loopback_ro_avg_attr(field); \
> +} while (0)
>
> #define gb_loopback_attr(field, type) \
> static ssize_t field##_show(struct device *dev, \
>
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev
|