On Fri, Dec 11, 2020 at 08:29:22PM +0800, wanghai (M) wrote: > > 在 2020/12/8 17:35, Johan Hovold 写道: > > On Sat, Dec 05, 2020 at 06:38:27PM +0800, Wang Hai wrote: > >> In gbaudio_dapm_free_controls(), if one of the widgets is not found, an error > >> will be returned directly, which will cause the rest to be unable to be freed, > >> resulting in leak. > >> > >> This patch fixes the bug. If if one of them is not found, just skip and free the others. > > Apart from the typo, please break your lines at 72 columns or so (not > > needed for the Fixes tag). > > Thanks for review, Do I need to send a v2 patch to change the commit msg? I'm not sure your mail reached the lists since it contains HTML, but to answer your question: Please do resend. If you can make the maintainers' life any easier that's always a good idea. You should include the Reviewed-by tags you've gotten so far when resending as long as you only update the commit message. Johan _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|