Hi Emmanouil,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.10-rc4 next-20201116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Emmanouil-Perselis/Fix-warning-for-static-const-char-array-in-audio_manager_module-c/20201117-044852
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 0d79a48440f559ac939d1be2089757c5e4ab16c7
config: microblaze-randconfig-r011-20201116 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/69022592162daaee87b29588cd562da4439f0517
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Emmanouil-Perselis/Fix-warning-for-static-const-char-array-in-audio_manager_module-c/20201117-044852
git checkout 69022592162daaee87b29588cd562da4439f0517
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/staging/greybus/audio_manager_module.c: In function 'send_add_uevent':
>> drivers/staging/greybus/audio_manager_module.c:162:3: error: initializer element is not constant
162 | name_string,
| ^~~~~~~~~~~
drivers/staging/greybus/audio_manager_module.c:162:3: note: (near initialization for 'envp[0]')
drivers/staging/greybus/audio_manager_module.c:163:3: error: initializer element is not constant
163 | vid_string,
| ^~~~~~~~~~
drivers/staging/greybus/audio_manager_module.c:163:3: note: (near initialization for 'envp[1]')
drivers/staging/greybus/audio_manager_module.c:164:3: error: initializer element is not constant
164 | pid_string,
| ^~~~~~~~~~
drivers/staging/greybus/audio_manager_module.c:164:3: note: (near initialization for 'envp[2]')
drivers/staging/greybus/audio_manager_module.c:165:3: error: initializer element is not constant
165 | intf_id_string,
| ^~~~~~~~~~~~~~
drivers/staging/greybus/audio_manager_module.c:165:3: note: (near initialization for 'envp[3]')
drivers/staging/greybus/audio_manager_module.c:166:3: error: initializer element is not constant
166 | ip_devices_string,
| ^~~~~~~~~~~~~~~~~
drivers/staging/greybus/audio_manager_module.c:166:3: note: (near initialization for 'envp[4]')
drivers/staging/greybus/audio_manager_module.c:167:3: error: initializer element is not constant
167 | op_devices_string,
| ^~~~~~~~~~~~~~~~~
drivers/staging/greybus/audio_manager_module.c:167:3: note: (near initialization for 'envp[5]')
>> drivers/staging/greybus/audio_manager_module.c:180:46: error: passing argument 3 of 'kobject_uevent_env' from incompatible pointer type [-Werror=incompatible-pointer-types]
180 | kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
| ^~~~
| |
| const char * const*
In file included from drivers/staging/greybus/audio_manager.h:11,
from drivers/staging/greybus/audio_manager_module.c:10:
include/linux/kobject.h:241:10: note: expected 'char **' but argument is of type 'const char * const*'
241 | char *envp[]);
| ~~~~~~^~~~~~
cc1: some warnings being treated as errors
vim +162 drivers/staging/greybus/audio_manager_module.c
8db00736d365b75 Svetlin Ankov 2016-01-13 151
8db00736d365b75 Svetlin Ankov 2016-01-13 152 static void send_add_uevent(struct gb_audio_manager_module *module)
8db00736d365b75 Svetlin Ankov 2016-01-13 153 {
8db00736d365b75 Svetlin Ankov 2016-01-13 154 char name_string[128];
8db00736d365b75 Svetlin Ankov 2016-01-13 155 char vid_string[64];
8db00736d365b75 Svetlin Ankov 2016-01-13 156 char pid_string[64];
d0af1bd5f6f4497 Pankaj Bharadiya 2016-10-16 157 char intf_id_string[64];
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 158 char ip_devices_string[64];
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 159 char op_devices_string[64];
8db00736d365b75 Svetlin Ankov 2016-01-13 160
69022592162daae Emmanouil Perselis 2020-11-16 161 static const char * const envp[] = {
8db00736d365b75 Svetlin Ankov 2016-01-13 @162 name_string,
8db00736d365b75 Svetlin Ankov 2016-01-13 163 vid_string,
8db00736d365b75 Svetlin Ankov 2016-01-13 164 pid_string,
d0af1bd5f6f4497 Pankaj Bharadiya 2016-10-16 @165 intf_id_string,
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 166 ip_devices_string,
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 167 op_devices_string,
8db00736d365b75 Svetlin Ankov 2016-01-13 168 NULL
8db00736d365b75 Svetlin Ankov 2016-01-13 169 };
8db00736d365b75 Svetlin Ankov 2016-01-13 170
8db00736d365b75 Svetlin Ankov 2016-01-13 171 snprintf(name_string, 128, "NAME=%s", module->desc.name);
8db00736d365b75 Svetlin Ankov 2016-01-13 172 snprintf(vid_string, 64, "VID=%d", module->desc.vid);
8db00736d365b75 Svetlin Ankov 2016-01-13 173 snprintf(pid_string, 64, "PID=%d", module->desc.pid);
d0af1bd5f6f4497 Pankaj Bharadiya 2016-10-16 174 snprintf(intf_id_string, 64, "INTF_ID=%d", module->desc.intf_id);
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 175 snprintf(ip_devices_string, 64, "I/P DEVICES=0x%X",
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 176 module->desc.ip_devices);
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 177 snprintf(op_devices_string, 64, "O/P DEVICES=0x%X",
a9234bfd6cec442 Vaibhav Agarwal 2016-03-30 178 module->desc.op_devices);
8db00736d365b75 Svetlin Ankov 2016-01-13 179
8db00736d365b75 Svetlin Ankov 2016-01-13 @180 kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
8db00736d365b75 Svetlin Ankov 2016-01-13 181 }
8db00736d365b75 Svetlin Ankov 2016-01-13 182
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|