On 7/29/20 5:51 AM, Viresh Kumar wrote: > On 28-07-20, 17:37, Alex Elder wrote: >> On 7/27/20 1:32 PM, Gustavo A. R. Silva wrote: >>> Replace the existing /* fall through */ comments and its variants with >>> the new pseudo-keyword macro fallthrough[1]. >>> >>> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through >> >> Thanks for the patch. It looks good, but it raises >> another question I'd like discussion on. >> >> It seems that Johan likes default (or final) cases in >> switch statements without a "break" statement. Viresh >> and Bryan appear to be fond of this too. >> >> It's pedantic, but I don't like that. Am I wrong? >> --> Johan/Viresh/Bryan would you please comment? > > I am not fond of them as they aren't required for the working of the code. It is > a bit like using an empty return statement for a routine with void return type, > though it surely adds some consistency to the switch case. I understand this perspective, and it's exactly why I wanted to have a conversation about it (rather than just saying it should be fixed). As similar example, I don't like unnecessary parentheses, but sometimes it's a good idea to have them. Thanks. -Alex > But if people really feel it must be there, then its fine :) > _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|