Re: [PATCH v3] staging: greybus: hid: remove braces {} around single statement block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/28/20 5:21 PM, Dan Jessie wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: braces {} are not necessary for single statement blocks
> 
> This is the only instance of the problem noted by
> checkpatch.pl in staging: greybus.
> 
> Signed-off-by: Dan Jessie <dtjessie@xxxxxxxxx>

Looks good, thanks.

Reviewed-by: Alex Elder <elder@xxxxxxxxxx>

> 
> ---
> v3: - Reworded patch message
>     - Added patch version history
> v2: - Noted this was the only place the issue is
>       reported, as suggested by Alex Elder
> ---
>  drivers/staging/greybus/hid.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> index 04bfd9110502..ed706f39e87a 100644
> --- a/drivers/staging/greybus/hid.c
> +++ b/drivers/staging/greybus/hid.c
> @@ -290,9 +290,8 @@ static int gb_hid_parse(struct hid_device *hid)
>  	}
>  
>  	rdesc = kzalloc(rsize, GFP_KERNEL);
> -	if (!rdesc) {
> +	if (!rdesc)
>  		return -ENOMEM;
> -	}
>  
>  	ret = gb_hid_get_report_desc(ghid, rdesc);
>  	if (ret) {
> 

_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev




[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux