Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Johan Hovold <johan@xxxxxxxxxx>
- Subject: Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow
- From: Takashi Iwai <tiwai@xxxxxxx>
- Date: Wed, 11 Mar 2020 11:02:33 +0100
- In-reply-to: <20200311095814.GI14211@localhost>
- References: <20200311091906.22980-1-tiwai@suse.de> <20200311095814.GI14211@localhost>
- User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
On Wed, 11 Mar 2020 10:58:14 +0100,
Johan Hovold wrote:
>
> On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buffer limit. Fix it by replacing with scnprintf().
> >
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > ---
> > drivers/staging/greybus/tools/loopback_test.c | 24 ++++++++++++------------
>
> Thanks for the fix.
>
> Would you mind resending with a "staging: greybus: loopback_test:"
> prefix since this is not a subsystem wide issue, bur rather a bug in a
> specific user-space tool?
OK, will do that.
thanks,
Takashi
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev
[Index of Archives]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]
[Asterisk Books]