Re: Potential memory leak in greybus/svc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Got it! Thanks for clarifying.

On Sun, Dec 15, 2019 at 7:13 AM Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> On Sat, Dec 14, 2019 at 05:44:05PM -0600, Navid Emamdoost wrote:
> > Hello,
> >
> > It seems to me there is a memory leak in the implementation of gb_svc_create().
> > In the error handling path (labeled as err_put_device) the code
> > correctly puts svc->dev, but I am suspicious that svc->wq is leaking.
> > The allocated svc->wq needs a release via destroy_workqueue() in the
> > error handling path. Am I missing something?
>
> You are. Just grep for destroy_workqueue() in that file to see where
> svc->wc is freed (and that function is called on final put_device()).
>
> Johan



-- 
Navid.
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev




[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux