On Sun, 2019-10-06 at 11:50 +0200, Greg KH wrote: > On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote: > > Fix CHECK: add blank line after declarations [] > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h [] > > @@ -24,6 +24,7 @@ struct gb_control { > > char *vendor_string; > > char *product_string; > > }; > > + > > #define to_gb_control(d) container_of(d, struct gb_control, dev) > > No, the original code is "better" here, it's a common pattern despite > what checkpatch.pl tells you, sorry. Statistics please. I believe it's not a common pattern. _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev