Hi, On Tue 27 Aug 2019 at 14:45, Greg Kroah-Hartman wrote: > On Tue, Aug 27, 2019 at 04:36:11PM +0300, Dan Carpenter wrote: >> I can't compile greybus so it's hard to run Smatch on it... I have a >> Smatch thing which ignores missing includes and just tries its best. >> It mostly generates garbage output but a couple of these look like >> potential issues: > > Why can't you compile the code? > I think we are missing includes in some of the greybus header files. > >> drivers/staging/greybus/operation.c:379 gb_operation_message_alloc() warn: check 'message_size' for integer overflows 'kzalloc()' > > That should be checked on line 368, right? > >> drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->channels' double freed >> drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->name' double freed > > I don't understand this warning, how are these potentially double freed? > > And the light.c file isn't moving out of drivers/staging/ just yet :) > I will take a look at this also. Cheers, Rui _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|