On Sun, 2019-03-31 at 01:20 -0500, Alex Elder wrote: > On 3/31/19 1:04 AM, Joe Perches wrote: > > Blind adherence to 80 column limits leads to poor looking > > code. Especially with longish identifier lengths. > I agree. If it were me, I'd use a local variable. For example: > > struct greybus_descriptor_cport *cport_desc = gbphy_dev->cport_desc; > ... > connection = gb_connection_create(gbphy_dev->bundle, > le16_to_cpu(cport_desc->id), NULL); > > Or maybe better: > > u16 cport_id = le16_to_cpu(gbphy_dev->cport_desc->id); > ... > connection = gb_connection_create(gbphy_dev->bundle, cport_id, NULL); True. A possible negative though: Temporaries that are only used once are sometimes less readable as the declaration is supposed to be done at an open brace and that could be relatively far away from the set and use. _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|