On Wed, Jan 09, 2019 at 11:58:24AM +0100, Johan Hovold wrote: > On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote: > > This patch drops gpio_chip_to_gb_gpio_controller(), > > and uses gpiochip_get_data() to retrieve the container > > of struct gpio_chip. > > So this will break the driver, since gpiochip_add() sets the data > pointer to NULL. > > These kind of changes are getting too complicated to do without > something to test against. We had a module simulator at one point, but > not sure what the state of that is now. > Ok, I get it. > I appreciate the effort though, and since we already started, let's try > to finish, but please drop this patch for now. > Ok I'll do that. > Johan Thanks for the review. Regards, Nishad _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|