Re: [PATCH 00/25] Change tty_port(standard)_install's return type

[Jaejoong Kim <climbbb.kim@xxxxxxxxx>]

Hi

On Wed, Sep 12, 2018 at 11:41 PM Alan Cox <gnomes@xxxxxxxxxxxxxxxxxxx> wrote:

On Tue,  4 Sep 2018 11:44:26 +0900
Jaejoong Kim <climbbb.kim@xxxxxxxxx> wrote:

> Many drivers with tty use the tty_stand_install(). But, there is no
> need to handle the error, since it always returns 0.


And what happens if another change means it can fail again. It's just a
property of the current implementation that it can't. It used to fail.

This seems to be a ton of unneccessary churn that will end up just having
to be reversed again some day in the future.

Hm. you maybe right if it has changes again with fail case. But, Is it better to modify it

than to leave it because it can change later?

Jaejoong

 

Alan

_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev