Re: [PATCH 00/25] Change tty_port(standard)_install's return type

[Jaejoong Kim <climbbb.kim@xxxxxxxxx>]

Hi,

Thanks for the review this.

On Tue, Sep 4, 2018 at 1:42 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

Hi Jaejoong.

> Change return type for tty functions. Patch No.01
>   tty: Change return type to void
Adding this patch first will generate a lot of warnings
until all users are updated.
It is usual practice to prepare all users
and then apply the infrastructure changes as the
last patch.
Then people will not see a lot of warnings when
they build something in the middle,
and I guess current stack set may also generate
a few mails from the 0-day build infrastructure.

OK. i will make a patch#1(tty: Change return type to void) last.

 

>   isdn: i4l: isdn_tty: Change return type to void

And a nitpick on the patch description.
This patch do not change any return type, but
it ignore the return value og tty_part_install().
Same goes for all ramaining patches.

 

You are right. I will rewrite commit title with V2.

Jaejoong

 

        Sam

_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev