Re: [PATCH 02/15] drm: make device_type const
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Bhumika Goyal <bhumirks@xxxxxxxxx>
- Subject: Re: [PATCH 02/15] drm: make device_type const
- From: Daniel Vetter <daniel@xxxxxxxx>
- Date: Fri, 25 Aug 2017 15:36:24 +0200
- In-reply-to: <1503130946-2854-3-git-send-email-bhumirks@gmail.com>
- Mail-followup-to: Bhumika Goyal <bhumirks@xxxxxxxxx>, julia.lawall@xxxxxxx, bp@xxxxxxxxx, mchehab@xxxxxxxxxx, daniel.vetter@xxxxxxxxx, jani.nikula@xxxxxxxxxxxxxxx, seanpaul@xxxxxxxxxxxx, airlied@xxxxxxxx, g.liakhovetski@xxxxxx, tomas.winkler@xxxxxxxxx, dwmw2@xxxxxxxxxxxxx, computersforpeace@xxxxxxxxx, boris.brezillon@xxxxxxxxxxxxxxxxxx, marek.vasut@xxxxxxxxx, richard@xxxxxx, cyrille.pitchen@xxxxxxxxxx, peda@xxxxxxxxxx, kishon@xxxxxx, bhelgaas@xxxxxxxxxx, thierry.reding@xxxxxxxxx, jonathanh@xxxxxxxxxx, dvhart@xxxxxxxxxxxxx, andy@xxxxxxxxxxxxx, ohad@xxxxxxxxxx, bjorn.andersson@xxxxxxxxxx, freude@xxxxxxxxxx, schwidefsky@xxxxxxxxxx, heiko.carstens@xxxxxxxxxx, jth@xxxxxxxxxx, jejb@xxxxxxxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, lduncan@xxxxxxxx, cleech@xxxxxxxxxx, johan@xxxxxxxxxx, elder@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, heikki.krogerus@xxxxxxxxxxxxxxx, linux-edac@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, fcoe-devel@xxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, open-iscsi@xxxxxxxxxxxxxxxx, greybus-dev@xxxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx
- References: <1503130946-2854-1-git-send-email-bhumirks@gmail.com> <1503130946-2854-3-git-send-email-bhumirks@gmail.com>
- User-agent: NeoMutt/20170609 (1.8.3)
On Sat, Aug 19, 2017 at 01:52:13PM +0530, Bhumika Goyal wrote:
> Make these const as they are only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
I can't apply this, it's missing your s-o-b line. You can just replay with
that.
Thanks, Daniel
> ---
> drivers/gpu/drm/drm_sysfs.c | 2 +-
> drivers/gpu/drm/ttm/ttm_module.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
> index 1c5b5ce..84e4ebe 100644
> --- a/drivers/gpu/drm/drm_sysfs.c
> +++ b/drivers/gpu/drm/drm_sysfs.c
> @@ -39,7 +39,7 @@
> * drm_connector_unregister().
> */
>
> -static struct device_type drm_sysfs_device_minor = {
> +static const struct device_type drm_sysfs_device_minor = {
> .name = "drm_minor"
> };
>
> diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c
> index 66fc639..e6604e0 100644
> --- a/drivers/gpu/drm/ttm/ttm_module.c
> +++ b/drivers/gpu/drm/ttm/ttm_module.c
> @@ -37,7 +37,7 @@
> static DECLARE_WAIT_QUEUE_HEAD(exit_q);
> static atomic_t device_released;
>
> -static struct device_type ttm_drm_class_type = {
> +static const struct device_type ttm_drm_class_type = {
> .name = "ttm",
> /**
> * Add pm ops here.
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev
[Index of Archives]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]
[Asterisk Books]