On Tue, Jul 18, 2017 at 04:26:40PM +0530, karthik@xxxxxxxxxxxx wrote:
> From: Karthik Tummala <karthik@xxxxxxxxxxxx>
>
> Enclosed multiple macro statements in a do - while loop as per kernel
> coding standard, pointed by checkpatch.
\
> static DEVICE_ATTR_RO(name##_avg)
>
> -#define gb_loopback_stats_attrs(field) \
> - gb_loopback_ro_stats_attr(field, min, u); \
> - gb_loopback_ro_stats_attr(field, max, u); \
> - gb_loopback_ro_avg_attr(field)
> +#define gb_loopback_stats_attrs(field) \
> +do { \
> + gb_loopback_ro_stats_attr(field, min, u); \
> + gb_loopback_ro_stats_attr(field, max, u); \
> + gb_loopback_ro_avg_attr(field); \
> +} while (0)
You obviously did not even compile-test this before submitting it, which
needless to say, is not ok.
Johan
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev
|