Re: [PATCH v2] staging: greybus: loopback_test: fix comment style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 05, 2017 at 10:01:09AM +0500, Aleksey Rybalkin wrote:
> On Tue, Jul 04, 2017 at 10:28:10AM +0200, Johan Hovold wrote:
> > On Tue, Jul 04, 2017 at 11:47:51AM +0530, Viresh Kumar wrote:
> > > + Greg
> > > 
> > > On 03-07-17, 23:27, Aleksey Rybalkin wrote:
> > > > According to checkpatch warning, block comments should align the * on
> > > > each line. Also, preferred style for multi-line comments is starting the
> > > > comment text after the second *.
> > > > 
> > > > Signed-off-by: Aleksey Rybalkin <aleksey@xxxxxxxxxxxx>
> > > > ---
> > 
> > Thanks for the v2. Next time remember to include a short changelog here
> > after the cut-off line.
> 
> Will do next time. And will send more meaningful patches, too. This
> was "learning the ropes" patch. Thanks for the feedback.

Sounds good, looks like you've got the hang of it.

> Also a question - is it ok to send "thanks for the feedback" emails
> with minimum substance like this one? I was hesitating for a minute to
> send it.

It certainly is.

Johan
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev




[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux