Re: [PATCH] staging: greybus: mark PM functions as __maybe_unused
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Arnd Bergmann <arnd@xxxxxxxx>
- Subject: Re: [PATCH] staging: greybus: mark PM functions as __maybe_unused
- From: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
- Date: Fri, 19 May 2017 09:10:07 +0530
- In-reply-to: <CAK8P3a2c_Q9gzmFqJmPkiz780M5s6+yN+q+3-PaOrYVz=Utc-Q@mail.gmail.com>
- References: <20170518132834.1744968-1-arnd@arndb.de> <20170518141800.GI17481@vireshk-i7> <CAK8P3a2c_Q9gzmFqJmPkiz780M5s6+yN+q+3-PaOrYVz=Utc-Q@mail.gmail.com>
- User-agent: Mutt/1.5.24 (2015-08-30)
On 18-05-17, 16:51, Arnd Bergmann wrote:
> I find that a lot of users get the #ifdef wrong, either using the wrong
> macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right
> set of functions (e.g. calling a function only from the suspend handler).
>
> The __maybe_unused annotation avoids both problems and also gives
> better build time coverage, so that's what I tend to use.
Thanks for the explanation Arnd. I hope these unused routines will not
be part of the binary that gets generated. Right?
Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev
[Index of Archives]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]
[Asterisk Books]