On Wed, Mar 01, 2017 at 01:49:44AM -0800, Jonathan Bowie wrote: > On Wed, Mar 01, 2017 at 10:46:01AM +0100, Johan Hovold wrote: > > On Wed, Mar 01, 2017 at 01:42:13AM -0800, Jonathan Bowie wrote: > > > Signed-off-by: Jonathan Bowie <eudjtb@xxxxxxxxx> > > > --- > > > > > > v1: > > > * Fixed inconsistent spacing around an arithmetic operator > > > > Almost right. This sentence should go in the commit message which is > > otherwise now empty (i.e. above you Signed-off-by). > > > > > v2: > > > * Corrected summary and commit message > > > > And this is the change log that goes below the cut-off line, just like > > you do here. > > > > And you forgot to CC the staging list. > > > > Third time's a charm? :) > > > > Thanks, > > Johan > > Was going by this guide https://kernelnewbies.org/PatchTipsAndTricks which said > changelog could be added prior to file name at the top of the patch. And that's correct, changelogs go below the cut-off line (---), it was just that you commit message was now empty (in v2), and you do not need a changelog entry for "v1:". The sentence you put there would do for a good commit message however. Thanks, Johan _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|