On Thu, Feb 09, 2017 at 01:01:18PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Currently newline.flow_control is uninitialized, so it can contain > any garbage from the stack. I believe it should be initialized with > GB_SERIAL_AUTO_RTSCTS_EN enabled if the termios c_cflag is CRTSCTS > enabled. Good catch. The CRTSCTS flag is actually honoured a bit further down in the set_termios(), but there's a bug in that it assumes newline to have been initialised with the current (old) values. It should unconditionally set the flow_control field rather than manipulate bits (we currently use one bit of this field). Care to send a v2 fixing this up as suggested above? Thanks, Johan _______________________________________________ greybus-dev mailing list greybus-dev@xxxxxxxxxxxxxxxx https://lists.linaro.org/mailman/listinfo/greybus-dev
|