Re: [PATCH v2 4/4] staging: greybus: audio: Ensure proper byte order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote:
> From: Vaibhav Agarwal <vaibhav.agarwal@xxxxxxxxxx>
> 
> Proper byte order was completely disregarded for multi byte data shared
> between AP and module (and APB1). Fix this.
> 
> Signed-off-by: Vaibhav Agarwal <vaibhav.agarwal@xxxxxxxxxx>
> ---

Hi Vaibhav.

I think you got them all except for this one in
audio_topology.c:gbcodec_mixer_dapm_ctl_put():

>>>	max = info->value.integer.max;	<<<
	mask = (1 << fls(max)) - 1;
	val = ucontrol->value.integer.value[0] & mask;
	connect = !!val;

Mark
--
_______________________________________________
greybus-dev mailing list
greybus-dev@xxxxxxxxxxxxxxxx
https://lists.linaro.org/mailman/listinfo/greybus-dev




[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux