Re: A comment regarding commit 96f14ed1c859d080038ad56d03ef3b0fd9797a9d

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mike Frysinger [Tue, Jun 10, 2008 at 08:11:45PM -0400]:
> On Tuesday 10 June 2008, Nico Schottelius wrote:
> > I saw that you introduce _GNU_SOURCE into gpm.
> > This may fix things for now, but I don't think it's the right way to go
> > with gpm.
> 
> that's why i didnt commit it to gpm-2.  the idea with gpm-1 is to just keep it 
> alive enough to work.

I thought almost the whole night about your commit und about solutions,
because I really dislike introducing -D_GNU_SOURCE.

But actually, you already choosed the right way.

> > I began in src/daemon/processconn.c and will continue until it compiles
> > within glibc 2.8 without the need for _GNU_SOURCE.
> >
> > Do you have some host I could test building on? Currently I don't have
> > an glibc 2.8 system installed somewhere.
> 
> "struct ucred" is not in POSIX.  if you want to be POSIX conformant, you'll 
> have to find a way to implement that code without it.

That's clear. That's why I removed it in commit
35d36c35c9d4949c9a3d8e1591d6b5a08432001a.
But that was a mistake for gpm-1, so reverted that commit in
dc89dd060f801c35d692ecb8d31f0e1e86968411.

The reason why  I asked for a buildhost with glibc-2.8 is that
I want to remove all those glibc-dependencies that are anyway
broken with glibc-2.8 in gpm-2-* branches.

So to make it short: Thanks for the quickfix for gpm-1.

Nico

-- 
Think about Free and Open Source Software (FOSS).
http://nico.schottelius.org/documentations/foss/the-term-foss/

PGP: BFE4 C736 ABE5 406F 8F42  F7CF B8BE F92A 9885 188C

Attachment: signature.asc
Description: Digital signature

_______________________________________________
gpm mailing list
gpm@xxxxxxxxxxxxxx
http://lists.linux.it/listinfo/gpm

[Index of Archives]     [Kernel Development]     [Red Hat Install]     [Red Hat Watch]     [Red Hat Development]     [Gimp]     [Yosemite News]