Re: some cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

> -#define CHECKFAIL(count)   ((count)==0 && noneofthem())
> +#define CHECKFAIL(count)   if (count==0) noneofthem();

please don't. This turns an expression into a statement, with definitely
no advantage. Besiders, the trailing semicolong is a blatant error.

Nico, please don't apply this part.

Similarly, the last hunk has no advantage. It's only more verbose
by using "else if" where "&&" is perfectly fine and definitely more
readable (since you don't need to track every else it its own it).

I've no comments on other hunks.  However, I'm definitely happy my
surname gets fixed :)

/alessandro


[Index of Archives]     [Kernel Development]     [Red Hat Install]     [Red Hat Watch]     [Red Hat Development]     [Gimp]     [Yosemite News]