You are right. I've put in a check into HEAD and v2_2_7_STABLE. Jan Zygmuntowicz Michal wrote: > But ret->m_h245Handler is not checked for NULL > and the crash seems to happen while accessing NULL > ret->m_h245Handler.. > > ----- Original Message ----- > From: "Jan Willamowius" <jan@xxxxxxxxxxxxxx> > Sent: Tuesday, May 13, 2008 9:15 AM > > > > Hi, > > > > the value of ret is checked 3 lines above in if(ret = <typecast>). > > If it is NULL, then this is a concurrency issue that would probably be > > better fixed with a lock. > > > > Regards, > > Jan > > > > Grzegorz Stanislawski wrote: > >> Zygmuntowicz Michal wrote: > >> > Could you examine this core dump and check ret->m_h245handler variable > >> > value > >> > (for NULL pointer). > >> > I guess we should add a NULL pointer check there. > >> > > >> As i wrote before ret is not resolving in gdb > >> (gdb) p ret > >> No symbol "ret" in current context. > >> but: > >> (gdb) p ((class CallSignalSocket *)remote)->m_h245handler > >> $1 = (H245Handler *) 0x0 > >> > >> For now i have changed SocketCleanupTimeout in [RoutedMode] to much > >> bigger value. > >> > >> Grzegorz Stanislawski > >> > >> > ----- Original Message ----- > >> > From: "Grzegorz Stanislawski" <stangrze@xxxxxxxxxx> > >> > Sent: Monday, May 12, 2008 11:00 AM > >> > Subject: 2.2.7 crash > >> > > >> > > >> > > >> >> Hi > >> >> Here is backtrace: > >> >> Program terminated with signal 11, Segmentation fault. > >> >> #0 0x08110046 in ~CallSignalSocket (this=0x8466c70) at > >> >> ProxyChannel.cxx:778 > >> >> 778 if > >> >> (!ret->m_h245handler->IsSessionEnded()) > >> >> (gdb) bt > >> >> #0 0x08110046 in ~CallSignalSocket (this=0x8466c70) at > >> >> ProxyChannel.cxx:778 > >> >> #1 0x0810c0c9 in ProxyHandler::CleanUp (this=0x41a13c48) > >> >> at ProxyChannel.cxx:5064 > >> >> #2 0x0806eb06 in SocketsReader::Exec (this=0x41a13c48) at > >> >> yasocket.cxx:838 > >> >> #3 0x08069118 in RegularJob::Run (this=0x41a13c48) at job.cxx:470 > >> >> #4 0x08069cb6 in Worker::Main (this=0x41a13ec0) at job.cxx:191 > >> >> #5 0x40ac5e5f in PThread::PX_ThreadStart (arg=0x41a13ec0) at > >> >> tlibthrd.cxx:1361 > >> >> #6 0x40be0240 in start_thread () from > >> >> /lib/tls/i686/cmov/libpthread.so.0 > >> >> #7 0x4104e49e in clone () from /lib/tls/i686/cmov/libc.so.6 > >> >> (gdb) p ret > >> >> No symbol "ret" in current context. > >> >> (gdb) p remote > >> >> $1 = (TCPProxySocket *) 0x82c1748 > >> >> > >> >> This happens every 2 days or so in system loaded by about 500 > >> >> terminals. > >> >> > >> >> Grzegorz Stanislawski -- Jan Willamowius, jan@xxxxxxxxxxxxxx, http://www.gnugk.org/ ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________________ Posting: mailto:Openh323gk-users@xxxxxxxxxxxxxxxxxxxxx Archive: http://sourceforge.net/mailarchive/forum.php?forum_name=openh323gk-users Unsubscribe: http://lists.sourceforge.net/lists/listinfo/openh323gk-users Homepage: http://www.gnugk.org/
