Hi,
the reasoning behind this code is that the caller doesn't know that he
is talking to multiple gateways and we have to make sure not to confuse
him about the current call state.
When we call the 2nd gateway, we use the stored setup message from the
first call. As soon as more messages have been exchanged there is a
good chance the 2nd call will fail simply because the caller can't match
his received messages with the partial call state from the first call.
This is a per call setting and thats why it is never set to false once
this state is reached.
It is probably possible to relax these rules in some circumstances, but
we need some feedback exactly under which conditions removing those
checks works and when it doesn't.
Secondly GnuGk might be able to store some FastStart elements and
rewrite messages containing them to relax those rules. But so far that
hasn't been implemented.
regards,
Jan
Alexandru Coseru wrote:
> Hello guys.
>
> I have found the following code in ProxyChannel.cxx (starting line 2221):
>
> if (m_call->IsCallInProgress() || m_call->IsFastStartResponseReceived()
> || m_call->IsH245ResponseReceived() ||
> m_h245socket != NULL) {
> PTRACE(5, "Q931\tFailover disabled for call " <<
> m_call->GetCallNumber());
>
> I have some comments , please reply on that.
>
> 1) IsCallInProgress - found code that is setting that to true , but
> found nothing to set it to false -> it means that always the condition will
> be true -> no failover
> 2) IsFastStartResponseReceived - we cannot do failover if
> FastStartResponse was received ?
> 3) IsH245ResponseReceived - same as 2)
>
> I'm asking you that because my failover doesn't work at all , all i got in
> logs was: Failover disabled for call xxxx
--
Jan Willamowius, jan@xxxxxxxxxxxxxx, http://www.gnugk.org/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________________
Posting: mailto:Openh323gk-users@xxxxxxxxxxxxxxxxxxxxx
Archive: http://sourceforge.net/mailarchive/forum.php?forum_id=8549
Unsubscribe: http://lists.sourceforge.net/lists/listinfo/openh323gk-users
Homepage: http://www.gnugk.org/
