Re: Changes in match_tariff function (sqlbill)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



You should consider groups to be an optional feature.
You are using it, but another person may not need it at all.
It is important difference, as someone else might write a patch
that works well for scenario that does not use groups
and does not work well for groups.
Would you be happy with such patch?;-)

Anyway, the problem is solved in the cvs.

----- Original Message ----- From: "Kompnet" <kompnet@xxxxxxxxx>
Sent: Monday, October 25, 2004 3:35 PM



What does it mean "default tariff (not assigned to any group/account)"?
I meant the default tariff is the tariff with the lowest priority.
But it must be assigned to any groups.
If I really understand you, you mean if user havn't grpid in voiptariffsel for
any destinations the tariff with grpid=NULL from voiptariff must be applied
for these destinations?
Well, if you think this is really importante difference I'll try to fix my
query.



On Monday 25 October 2004 14:04, Zygmuntowicz Michal wrote:
Unfortunatelly, your patch does not work fine.
It cannot find a default tariff (not assigned to any group/account)
- did you really check it?

----- Original Message -----
From: "Kompnet" <kompnet@xxxxxxxxx>
Sent: Friday, October 22, 2004 9:03 AM

> Michal, hi.
> The new patch works fine with default and other groups.
> In attachment you can find EXPLAIN ANALYZE output.
> I hope you'll apply it to the CVS. I thought it was in CVS at least 1.5
> month
> ago.
> Igor.
>
> On Tuesday 31 August 2004 17:21, you wrote:
>> And assign it to each new account... Not the best idea too.
>> But your patch is very useful, so I will modify it a bit to work
>> well with default tariffs too and apply it to the cvs.
>>
>> Did you check the query with EXPLAIN? Is it using indices
>> in a correct way, so it is fast?
>>
>> ----- Original Message -----
>> From: "Kompnet" <kompnet@xxxxxxxxx>
>> Sent: Tuesday, August 31, 2004 3:11 PM
>>
>> > I've not checked it, but it (default tariff with no group/selector) >> > is
>> > not necessary in my way: you can set 'default' group 1.
>> >
>> > On Tuesday 31 August 2004 16:52, you wrote:
>> > > I've got the idea - it's good. But isn't your patch breaking
>> > > tariff matching for default tariffs (with no group/selector)?
>> > >
>> > > ----- Original Message -----
>> > > From: "Kompnet" <kompnet@xxxxxxxxx>
>> > > To: <openh323gk-users@xxxxxxxxxxxxxxxxxxxxx>; "Zygmuntowicz >> > > Michal"
>> > > <m.zygmuntowicz@xxxxxxx> Sent: Tuesday, August 31, 2004 1:51 PM
>> > > Subject: Changes in match_tariff function
>> > > (sqlbill)
>> > >
>> > > > Hi, Michal.
>> > > > I've changed you match_tariff function a little.
>> > > > If it's needed to apply this schema:
>> > > > the 1-st user must can place calls whit prefix 1234# with common
>> > > > price, for the 2-nd user tariffs must be different for different
>> > > > destinations, but he use 1234# prefix too,
>> > > > and we use your variance of match_tariff, we need to write all
>> > > > destinations for both users:
>> > > > user1 1234#1 price1
>> > > > user2 1234#1 price2
>> > > > user1 1234#2 price1
>> > > > user2 1234#2 price3
>> > > > user1 1234#3 price1
>> > > > user2 1234#3 price4
>> > > > ...
>> > > > In my variance we can to write destinations separately for each
>> > > > user:
>> > > > user1 1234# price1
>> > > > user2 1234#1 price2
>> > > > user2 1234#2 price3
>> > > > user2 1234#2 price4
>> > > > .....
>> > > > --
>> > > > Best regards,
>> > > > Igor Prokhorov



------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl

_______________________________________________________

List: Openh323gk-users@xxxxxxxxxxxxxxxxxxxxx
Archive: http://sourceforge.net/mailarchive/forum.php?forum_id=8549
Homepage: http://www.gnugk.org/

[Index of Archives]     [SIP]     [Open H.323]     [Gnu Gatekeeper]     [Asterisk PBX]     [ISDN Cause Codes]     [Yosemite News]

  Powered by Linux