Re: Building GNU Classpath on Fedora 17

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> On Tue, Mar 12, 2013 at 12:47 PM, Andrew Hughes
> <gnu.andrew@xxxxxxxxxx> wrote:
> > Looking at rpm -ql gettext-devel on my RHEL system, it seems to add
> > a slew
> > of m4 files to /usr/share/aclocal.  Maybe if -e
> > /usr/share/aclocal/gettext.m4
> > in autogen.sh would be sufficient?
> 
> The attached patch works for me. Does it look OK to commit?
> 

I don't really see the need for the have_gettext variable.  Wouldn't:

if [ ! -e /usr/share/aclocal/gettext.m4 ] ; then 
	echo
	echo "You must have gettext installed to compile $PROJECT."
	DIE=1
fi

be simpler?

I am a little worried that there are systems where gettext.m4 will not
be in that location.  Using the result of $(aclocal --print-ac-dir) instead
of /usr/share/aclocal would be a better option i.e.

if [ ! -e $(aclocal --print-ac-dir)/gettext.m4 ] 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




[Index of Archives]     [Linux Kernel]     [Linux Cryptography]     [Fedora]     [Fedora Directory]     [Red Hat Development]

  Powered by Linux