Re: Patch to compile Escher with Classpath.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il giorno dom, 02/05/2010 alle 02.57 -0300, Marcos Roriz ha scritto:
> I finished up a patch that compiles the current Escher (Hg) with the
> current GNU Classpath (CVS). The major problems in the compilation was
> the difference between method name and the number/types of parameters
> in classpath and escher. After some fixing everything is fine. Now
> I'll generate some simple application tests (Hello World GUI, as Mario
> Torre said =D).
> 
> Regards,
> 
> Marcos Roriz

Hi Marcos,

Thanks for the patch!

I see there are a number of white space changes that make difficult to
read the patch.

Those white space changes are also affecting the formatting, so it's not
OK, because they break the GNU coding guidelines.

Please, try to export the patch ignoring white spaces changes and
resubmit.

Other than that, it looks good though, so now post a screen shot of your
first Escher based HelloWorld somewhere!! :)

Cheers,
Mario
-- 
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

Proud GNU Classpath developer: http://www.classpath.org/
Read About us at: http://planet.classpath.org
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:
http://endsoftpatents.org/



[Index of Archives]     [Linux Kernel]     [Linux Cryptography]     [Fedora]     [Fedora Directory]     [Red Hat Development]

  Powered by Linux