Re: [PATCH] MD4/MD5 fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Andrew" == Andrew Haley <aph@xxxxxxxxxx> writes:

>> Perhaps we should replace these uses with Integer.rotateLeft, for
>> clarity.

Andrew> In MD5?  Nooooooooooooo! Please!

Andrew> At least, not until this stuff gets inlined everywhere...

Yeah.  I thought about this more after I wrote the note.

I think we should treat this idiom like "f != f" as a NaN test --
something that Classpath developers have to know or learn.

At least for gcj inlining Integer methods is a pain for various
reasons.  Ideally we would fix this as well, though (at least for C++
ABI code).

Tom


[Index of Archives]     [Linux Kernel]     [Linux Cryptography]     [Fedora]     [Fedora Directory]     [Red Hat Development]

  Powered by Linux