Hi Mario, On Wed, 2006-12-06 at 13:18 +0100, Mario Torre wrote: > This patch moves the logic to build a CollationElementIterator from > RuleBasedCollator and Collator into the class CollationElementIterator > itself. > > *This is not a fix*. Infact, actually the new Constructor just read a > string out of the iterator, without any processing. But in the old code the decomposing is done, although not really in the classpath case, only in the case of libgcj. Could you explain the difference between classpath/libgcj here and how this actually helps us? Can't we use the libgcj version? > This way we can declare the 1.3 completeness and I can start fixing the > CollationElementIterator in just one place. > > I would like to have this in for 0.93, but I understand that this is not > a fix... > > What do you think? It doesn't really add or remove functionality it seems. How is the user better of with this version than they were with the old one? If it helps you structure the code in a way that makes improving it better please do go for it. But if the functionality doesn't really change I am not sure the user will actually care which version is in 0.93 (I am not opposed to adding it though). Cheers, Mark
Attachment:
signature.asc
Description: This is a digitally signed message part
