Re: Mauve regressions 0.92/0.93-pre

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello again,

> - gnu.javax.swing.text.html.parser.support.Parser.Text
> - gnu.javax.swing.text.html.parser.support.Parser.textPreProcessor_Test
> 
> Both fail with subtle differences in the result of what gets parsed. is
> this caused by the changes on how to handle whitespace?

Yeah this is whitespace handling differences. I'm pretty sure that the
whitespacehandling is now quite OK and closer to the specs. At least we
can parse most whitespace related special constructs much better than
before. I'm thinking that we/I should:
1. Add some tests for the official API that tests certain special
WS-related constructs and test the actual outcome in the form of the
element structure.
2. Remove these classpath-specific tests OR adjust them and move into
classpath's testsuite tree.

> - java.awt.image.IndexColorModel.getAlpha
> Fails with the following stacktrace:
> java.lang.ArrayIndexOutOfBoundsException: 99
>    at java.awt.image.IndexColorModel.getAlpha(IndexColorModel.java:585)
>    at gnu.testlet.java.awt.image.IndexColorModel.getAlpha.test(getAlpha.java:76)
>    at RunnerProcess.runtest(RunnerProcess.java:360)
>    at RunnerProcess.runAndReport(RunnerProcess.java:415)
>    at RunnerProcess.main(RunnerProcess.java:227)

Seems like the JDK has some form of mimimum color map size here, where
the internal color map is allocated at least 256 bytes, no matter what
is specified in the constructor. I am not sure if we need to follow the
RI behaviour here. While most color maps are 256 bytes aligned, I think
this is not really relevant. At least it is not specified. Should we
make the test less pedantic, or should we adjust our impl and the test
to behave closer to the RI behaviour (I already have my sources adjusted
to that, so that way would be trivial too...)

More checks coming tomorrow.

/Roman




[Index of Archives]     [Linux Kernel]     [Linux Cryptography]     [Fedora]     [Fedora Directory]     [Red Hat Development]

  Powered by Linux