On Fri, 2006-03-03 at 16:05 -0500, Thomas Fitzsimmons wrote:
> Yes, I agree. This patch looks good, and even avoids force-realizing
> widgets with gtk_widget_realize, while satisfying the AWT's
> peer-creation criteria. One small request: that you expand
> Component.addNotify's javadocs to describe these criteria clearly for
> future reference.
Good point. I only realized (pun intended) that setParent() would do the
right thing in the constructor because of the way addNotify() is called.
Documented as follows:
2006-03-03 Mark Wielaard <mark@xxxxxxxxx>
* java/awt/Component.java (addNotify): Expand documentation.
diff -u -r1.104 Component.java
--- java/awt/Component.java 28 Feb 2006 11:27:15 -0000 1.104
+++ java/awt/Component.java 3 Mar 2006 21:10:40 -0000
@@ -3426,10 +3426,11 @@
}
/**
- * Called to inform this component it has been added to a container.
- * A native peer - if any - is created at this time. This method is
- * called automatically by the AWT system and should not be called by
- * user level code.
+ * Called when the parent of this Component is made visible or when
+ * the Component is added to an already visible Container and needs
+ * to be shown. A native peer - if any - is created at this
+ * time. This method is called automatically by the AWT system and
+ * should not be called by user level code.
*
* @see #isDisplayable()
* @see #removeNotify()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://developer.classpath.org/pipermail/classpath/attachments/20060303/2c44eee6/attachment.pgp
