On Tue, 2006-02-21 at 10:42 -0500, Anthony Balkissoon wrote: > This is committed as: > > 2006-02-21 Anthony Balkissoon <abalkiss@xxxxxxxxxx> > > * java/math/MathContext.java: New class. > * java/math/RoundingMode: New Enum. > > In response to Andrew and Tom: > > Andrew: Yes, the only thing restricting this to the generics branch is > the Enum. But reading Sun's arguments in favour of Enums > (http://java.sun.com/j2se/1.5.0/docs/guide/language/enums.html) , they > make some reasonable points. So maybe the pity isn't that they use > Enums here but that we're still not able to handle them on the trunk. > I'm not sure how far away that is though - from what I understand it's > because not all the compilers we use support the new language features? > Yes, I can see their reasons for using them. It's just a shame that having that all the new math changes, AFAICS, are dependent on that enum, which locks it down to the branch. The problem is that ecj is the only FOSS compiler that can currently compile this stuff. I think the plan is to now merge this with gcj to provide this functionality for that. I don't know if anyone is still even working on this for jikes. > Tom: Yeah, the header template isn't there, and also the Eclipse builder > options don't seem to be working properly. Everytime I made any small > change it would do an entire rebuild, running autogen, configure, > ClasspathHeaders, BuildNative, etc. > Andrew Overholt gave it a quick look for me but we didn't see the > problem so we just worked around it on my local machine. > > > That's all for now, I should have some more java.math stuff ready soon. > > --Tony > > On Tue, 2006-02-21 at 08:32 +0000, Andrew John Hughes wrote: > > On Mon, 2006-02-20 at 17:33 -0500, Anthony Balkissoon wrote: > > > On Mon, 2006-02-20 at 15:09 -0500, Anthony Balkissoon wrote: > > > > This is RFC because it's my first commit to the generics branch and I > > > > just want to make sure there aren't any special procedures I forgot. > > > > > > > > 2006-02-20 Anthony Balkissoon <abalkiss@xxxxxxxxxx> > > > > > > > > * java/math/RoundingMode: New Enum. > > > > > > > > --Tony > > > > > > > > > This is replaced by: > > > 2006-02-20 Anthony Balkissoon <abalkiss@xxxxxxxxxx> > > > > > > * java/math/MathContext.java: New class. > > > * java/math/RoundingMode: New Enum. > > > > > > Also, I forgot to put the GNU Classpath header in RoundingMode, but this > > > patch includes it. Comments are still appreciated. I'll commit this > > > tomorrow if no one objects. > > > > > > --Tony > > > > Looks fine to me -- the header would have been my only comment. Of > > course, I'm assuming it applies cleanly and compiles... ;) > > > > It's a pity this new math stuff uses an enum for RoundingMode, because > > AFAICS that's the only thing that restricts this to the generics branch. -- Andrew :-) Please avoid sending me Microsoft Office (e.g. Word, PowerPoint) attachments. See http://www.fsf.org/philosophy/no-word-attachments.html If you use Microsoft Office, support movement towards the end of vendor lock-in: http://opendocumentfellowship.org/petition/ "Value your freedom, or you will lose it, teaches history. `Don't bother us with politics' respond those who don't want to learn." -- Richard Stallman Escape the Java Trap with GNU Classpath! http://www.gnu.org/philosophy/java-trap.html public class gcj extends Freedom implements Java { ... }
