I see two design / implementation problems with that mechanism:
The mutex that guards the log file is likely under constant contention.
The fact that each worker thread perform the IO by himself, thus slowing his "real" work.
Initial tests, done by removing logging from the regression testing, shows an improvement of about 20% in run time. This indicates we’re taking a pretty heavy performance hit just because of the logging activity.
Hi Barak Sason Rofman. Amazing perf improvement! Could show me
the detail test method ?
Thanks
-Xie
In addition to these problems, the logging module is due for an upgrade:
There are dozens of APIs in the logger, much of them are deprecated - this makes it very hard for new developers to keep evolving the project.
One of the key points for Gluster-X, presented in October at Bangalore, is the switch to a structured logging all across gluster.
________ Community Meeting Calendar: APAC Schedule - Every 2nd and 4th Tuesday at 11:30 AM IST Bridge: https://bluejeans.com/441850968 NA/EMEA Schedule - Every 1st and 3rd Tuesday at 01:00 PM EDT Bridge: https://bluejeans.com/441850968 Gluster-users mailing list Gluster-users@xxxxxxxxxxx https://lists.gluster.org/mailman/listinfo/gluster-users
