Alessandro De Salvo [Alessandro.DeSalvo@xxxxxxxxxxxxx] wrote:
> Hi Malahal,
>
> --- nfs-ganesha.orig/src/nfs-ganesha.spec-in.cmake 2015-06-16 00:11:31.477442950 +0200
> +++ nfs-ganesha/src/nfs-ganesha.spec-in.cmake 2015-06-15 22:11:57.068726917 +0200
> @@ -72,13 +72,13 @@
> @BCOND_GUI_UTILS@ gui_utils
> %global use_gui_utils %{on_off_switch gui_utils}
>
> -%global dev_version %{lua: extraver = string.gsub('@GANESHA_EXTRA_VERSION@', '%-', '.'); print(extraver) }
> +%global dev_version %{lua: extraver = string.gsub('@GANESHA_EXTRA_VERSION@', '%-', ''); print(extraver) }
I think the idea here is to replace any hyphens with DOTs in the
EXTRA_VERSION. The original statement should be fine provided we don't
start the EXTRA_VERSION with hyphen. Your change fixes the usual hyphen
we put in the extra version. I think we should remove that extra hyphen.
> Name: nfs-ganesha
> Version: @GANESHA_BASE_VERSION@
> -Release: 0%{dev_version}%{?dist}
> +Release: %{dev_version}%{?dist}
This looks to be the key change that is needed. Looks like a hyphen is
inserted between BASE_VERSION and EXTRA_VERSION in the rpm names by
by someone.
So, I made the above "Release" change and made GANESHA_EXTRA_VERSION to
just "2" instead of current "-2". The rpms generated were fine but the
tar file produced by "make dist" was
nfs-ganesha-2.2.08-0.1.1-Source.tar.gz. A bit ugly...
Can anyone please review Alessandro's changes and my comments?
> > So either EPEL has a broken spec file or V2.2.0 is broken.
>
> I tend to say it’s 2.2.0-2 which is broken, but it’s just my opinion.
> At any rate, 2.2.0-3 is working, and this is indeed good news.
There isn't any difference between V2.2.0-2 and V2.2.0-3 other than
some GLUSTER FSAL changes and a lone GPFS FSAL config change. I am
pretty sure this is some process issue rather than a code issue in
V2.2.0-2.
Regards, Malahal.
_______________________________________________
Gluster-users mailing list
Gluster-users@xxxxxxxxxxx
http://www.gluster.org/mailman/listinfo/gluster-users
