On 02/25/2013 10:51 AM, Amar Tumballi wrote: > On 10/21/2012 02:53 AM, Anand Avati wrote: > >> More details on how to write test cases with examples and how the >> framework works can be found at - >> >> 1. "tests: pre-commit regression tests" >> https://github.com/gluster/glusterfs/commit/bb41c8ab88f1a3d8c54b635674d0a72133623496 >> >> 2. tests/README in glusterfs.git >> 3. Example new change - http://review.gluster.org/4114 >> >> Please offer feedback on how the framework can be improved (inclusion of >> more tools?) to capture test cases better. >> > > This is a simple question on guide lines of writing a test case, and has > raised due to failure of tests for patch http://review.gluster.org/4567 > in particular. > > Looks like the failure of the tests for this patch (logs here > http://build.gluster.org/job/regression/729/consoleFull ) are due to > missing 'cleanup;' at the end of the script added in this patch. But the > question is, should the test script always 'assume' it starts from a > clean slate, or should it call a 'cleanup;' at the beginning all the time? > > It would help me to review the patchsets by having clear answer to this. > I consider bug-000000.t to be the template and it does contain cleanup at the end of it. Maybe we should add this detail to tests/README? -Vijay
