Segfault in gluster volume heal

B.Candler at pobox.com (Brian Candler) · Sat, 14 Jul 2012 20:14:51 +0100

On Sat, Jul 14, 2012 at 11:13:22AM -0500, Gerald Brandt wrote:
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x00007ffff6fcf0d0 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> > (gdb) bt
> > #0  0x00007ffff6fcf0d0 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> > #1  0x00007ffff6fd0f86 in strftime_l () from
> > /lib/x86_64-linux-gnu/libc.so.6
> > #2  0x00000000004206a6 in cmd_heal_volume_brick_out ()

I see a dubious bit of code there:

        uint32_t        time = 0;
...
                        tm = localtime ((time_t*)(&time));

That should be (IMO):

        time_t          time = 0;
...
                        tm = localtime (&time);

In particular, on a 64-bit platform, time_t is almost certainly not a 32-bit
quantity.

Regards,

Brian.