Thanks for the initiative Paul. Let me answer the major question from the thread.
> > Remove the trailer? Or fix it?
-Amar
--
On Tue, Jul 27, 2021 at 7:45 PM Paul Jakma <paul@xxxxxxxxx> wrote:
Hi,
The magic trailer added at the end of memory allocations in mem-pool.c
doesn't have its alignment ensured. This can lead to SIGBUS and
abnormal exits on some platforms (e.g., SPARC64).
I have a patch to round-up the header and allocation size to get the
right alignment for the trailer (I think).
It does complicate the memory allocation a little further.
Question is whether it would just be simpler to remove the trailer, and
simplify the code?
There are a number of external tools that exist to debug memory allocs,
from runtime loadable debug malloc libraries, to compiler features
(ASAN, etc.), to valgrind.
Glusterfs could just rely on those, and so simplify and (perhaps)
speed-up its own, general-case memory code.
Remove the trailer? Or fix it?
regards,
--
Paul Jakma | paul@xxxxxxxxx | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
Many people are secretly interested in life.
-------
Community Meeting Calendar:
Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://meet.google.com/cpu-eiue-hvk
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel
------- Community Meeting Calendar: Schedule - Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC Bridge: https://meet.google.com/cpu-eiue-hvk Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx https://lists.gluster.org/mailman/listinfo/gluster-devel
