Re: Toggle storage.linux-aio and volume restart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/12/20 10:39 am, Ravishankar N wrote:

On 08/12/20 9:15 pm, Dmitry Antipov wrote:
IOW if aio_configured is true, fops->readv and fops->writev should be set to posix_aio_readv() and posix_aio_writev(), respectively. But the whole picture looks like something in xlator graph silently reverts fops->readv and fops->writev back to posix_xxxv() defaults.
Looks like the (priv->io_uring_configured) check (I added this) which comes after the (priv->aio_configure check) in posix_reconfigure() is overwriting this.

And considering we do not have graph switch implemented on the server side, it is undesirable to toggle the fop dispatch table when there could be in-fight fops. Perhaps we should disallow changing linux-aio on the fly, like how it is done for linux-io_uring (see the check added in glusterd_op_stage_set_volume() for io_uring).

-Ravi


-Ravi

-------

Community Meeting Calendar:
Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://meet.google.com/cpu-eiue-hvk

Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel


-------

Community Meeting Calendar:
Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://meet.google.com/cpu-eiue-hvk

Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel




[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux