Dear Gluster Devels,
i am using gluster 5.10 and want to introduce a new volume option. Therefore I want to set a proper GD_OP_VERSION for it. In gluster 5.10 source code there is no macro defined for 51000.
But concurrently the GD_OP_VERSION_MAX is set to 50400. I would do something like this:
1. Change in libglusterfs/src/globals-h (line 47)
#define GD_OP_VERSION_MAX \
GD_OP_VERSION_5_10
GD_OP_VERSION_5_10
2. Add line to same Header file:
#define GD_OP_VERSION_5_10 51000 /* Op-version for GlusterFS 5.10 */
Do you think this is fine?
3. libglusterfs/src/common-utils.c (line 2036):
On the other side there is a if-branch which uses GD_OP_VERSION_5_4 which is currently the
GD_OP_VERSION_MAX. Why it is used here and should I increase it also to
GD_OP_VERSION_5_10?
Regards
David Spisla
_______________________________________________ Community Meeting Calendar: APAC Schedule - Every 2nd and 4th Tuesday at 11:30 AM IST Bridge: https://bluejeans.com/441850968 NA/EMEA Schedule - Every 1st and 3rd Tuesday at 01:00 PM EDT Bridge: https://bluejeans.com/441850968 Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx https://lists.gluster.org/mailman/listinfo/gluster-devel
