Re: CI failure - NameError: name 'unicode' is not defined (related to changelogparser.py)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Update:

The issue happened because python3 got installed on centos7.x series of builders due to other package dependencies. And considering GlusterFS picks python3 as priority even if python2 is default, the tests started to fail. We had completed the work of migrating the code to work smoothly with python3 by glusterfs-6.0 release, but had not noticed issues with regression framework as it was running only on centos7 (python2) earlier.

With this event, our regression tests are also now compatible with python3 (Thanks the the below mentioned patch of Kotresh). We were able to mark few spurious failures as BAD_TEST, and fix all the python3 related issues in regression by EOD Friday, and after watching regression tests for 1 more day, can say that the issues are now resolved.

Please resubmit (or rebase in the gerrit web) before triggering the 'recheck centos' in the submitted patch(es).

Thanks everyone who responded quickly once the issue was noticed, and we are back to GREEN again.

Regards,
Amar



On Fri, Jun 7, 2019 at 10:26 AM Deepshikha Khandelwal <dkhandel@xxxxxxxxxx> wrote:
Hi Yaniv,

We are working on this. The builders are picking up python3.6 which is leading to modules missing and such undefined errors.

Kotresh has sent a patch https://review.gluster.org/#/c/glusterfs/+/22829/ to fix the issue.



On Thu, Jun 6, 2019 at 11:49 AM Yaniv Kaul <ykaul@xxxxxxxxxx> wrote:
From [1].

I think it's a Python2/3 thing, so perhaps a CI issue additionally (though if our code is not Python 3 ready, let's ensure we use Python 2 explicitly until we fix this).

00:47:05.207 ok  14 [     13/    386] <  34> 'gluster --mode=script --wignore volume start patchy'
00:47:05.207 ok  15 [     13/     70] <  36> '_GFS --attribute-timeout=0 --entry-timeout=0 --volfile-id=patchy --volfile-server=builder208.int.aws.gluster.org /mnt/glusterfs/0'
00:47:05.207 Traceback (most recent call last):
00:47:05.207   File "./tests/basic/changelog/../../utils/changelogparser.py", line 233, in <module>
00:47:05.207     parse(sys.argv[1])
00:47:05.207   File "./tests/basic/changelog/../../utils/changelogparser.py", line 221, in parse
00:47:05.207     process_record(data, tokens, changelog_ts, callback)
00:47:05.207   File "./tests/basic/changelog/../../utils/changelogparser.py", line 178, in process_record
00:47:05.207     callback(record)
00:47:05.207   File "./tests/basic/changelog/../../utils/changelogparser.py", line 182, in default_callback
00:47:05.207     sys.stdout.write(u"{0}\n".format(record))
00:47:05.207   File "./tests/basic/changelog/../../utils/changelogparser.py", line 128, in __str__
00:47:05.207     return unicode(self).encode('utf-8')
00:47:05.207 NameError: name 'unicode' is not defined
00:47:05.207 not ok  16 [     53/     39] <  42> '2 check_changelog_op /d/backends/patchy0/.glusterfs/changelogs RENAME' -> 'Got "0" instead of "2"'


Y.

[1] https://build.gluster.org/job/centos7-regression/6318/console
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel

_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel



--
Amar Tumballi (amarts)
_______________________________________________

Community Meeting Calendar:

APAC Schedule -
Every 2nd and 4th Tuesday at 11:30 AM IST
Bridge: https://bluejeans.com/836554017

NA/EMEA Schedule -
Every 1st and 3rd Tuesday at 01:00 PM EDT
Bridge: https://bluejeans.com/486278655

Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel


[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux