On Mon, Sep 10, 2018 at 3:37 PM, Nigel Babu <nigelb@xxxxxxxxxx> wrote:
Hello folks,
We now have review.gluster.org as an external tracker on Bugzilla. Our current automation when there is a bugzilla attached to a patch is as follows:
1. When a new patchset has "Fixes: bz#1234" or "Updates: bz#1234", we will post a comment to the bug with a link to the patch and change the status to POST. 2. When the patchset is merged, if the commit said "Fixes", we move the status to MODIFIED.
- I don't see a need for a comment if you add the external tracker (as suggested below).
- You really need some complex (but doable!) logic to look at the branch where the commit took place and the target release in Bugzilla to correctly move to MODIFIED state.
(there's also a corner case where multiple patches are needed for a bug, btw. Need to see all patches were merged, etc. before moving to MODIFIED).
Y.
I'd like to propose the following improvements:1. Add the Gerrit URL as an external tracker to the bug.2. When a patch is merged, only change state of the bug if needed. If there is no state change, do not add an additional message. The external tracker state should change reflecting the state of the review.3. Assign the bug to the committer. This has edge cases, but it's best to at least handle the easy ones and then figure out edge cases later. The experience is going to be better than what it is right now.
Please provide feedback/comments by end of day Friday. I plan to add this activity to the next Infra team sprint that starts on Monday (Sep 17).
--
nigelb
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx https://lists.gluster.org/mailman/listinfo/gluster-devel
