Re: Removal of use-compound-fops option in afr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Mon, Mar 5, 2018 at 7:10 PM, Shyam Ranganathan <srangana@xxxxxxxxxx> wrote:
On 03/04/2018 10:15 PM, Pranith Kumar Karampuri wrote:
> Shyam,
>     Do let me know if there is anything that needs to be done on the
> process front.

I see that use-compound-fops is now deprecated, which is something that
users need to be aware of.

So when preparing release-notes, for when this change will hit a release
(or are you intending to backport this?), we need to call out the same.
The process for such a change is to look for github issues across the
commits, and will get missed if this is a bug.

At times bugs are fine, but again in this case, the bug reads eager lock
changes, and the commit is to remove compounding. So users again may not
be aware of the change looking at the bug list.

So overall, from a process (and a release) standpoint, I would have
preferred a github issue (or a bug, which for this change seems not to
be the case), that calls out that this feature is to be deprecated/disabled.

Patch is yet to be merged. I am waiting for any further comments on this thread.
I will change the patch to use the following github issue. I also added some history
and reasoning as to why I am of the opinion to remove it now on the issue.

https://github.com/gluster/glusterfs/issues/414

I will wait till tomorrow morning IST before merging the patch in case there are no
further comments.


HTH.

>
> On Mon, Mar 5, 2018 at 8:18 AM, Pranith Kumar Karampuri
> <pkarampu@xxxxxxxxxx <mailto:pkarampu@xxxxxxxxxx>> wrote:
>
>     hi,
>           We found that compound fops is not giving better performance
>     in replicate and I am thinking of removing that code. Sent the patch
>     at https://review.gluster.org/19655 <https://review.gluster.org/19655>
>
>     --
>     Pranith
>
>
>
>
> --
> Pranith



--
Pranith
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux