Re: tests/basic/pump.t - what is it used for?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



All I know is pump translator is written long back to support 'replace-brick' without data-loss in distributed setup too. But we figured out pump is not maintainable along the way, and said you can't do a replace-brick in distributed volume type.

https://github.com/gluster/glusterfs/commit/acdeed002d30209e0a058c2df0346d4f16c08994

I don't see that its used now, so looks like we can remove this test. 

-Amar

On Fri, Sep 8, 2017 at 10:02 AM, Atin Mukherjee <amukherj@xxxxxxxxxx> wrote:
Pranith,

I see you're the author of the test in $Subj. Now while I was working on a patch https://review.gluster.org/#/c/18226/ to disallow replace brick operations on dist only volumes the patch failed the regression on this test as the test actually uses replace brick on a distribute only volume which IMO is wrong as then this would always end up in to data loss situation. I'd need some context here to understand the expectation of this test before doing any modifications.

~Atin

_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://lists.gluster.org/mailman/listinfo/gluster-devel



--
Amar Tumballi (amarts)
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux