On Fri, Jun 23, 2017 at 9:55 AM, Pranith Kumar Karampuri <pkarampu@xxxxxxxxxx> wrote:
On Fri, Jun 23, 2017 at 9:37 AM, Ravishankar N <ravishankar@xxxxxxxxxx> wrote:On 06/23/2017 09:15 AM, Pranith Kumar Karampuri wrote:
hi,Now that we are doing backports with same Change-Id, we can find the patches and their backports both online and in the tree without any extra information in the commit message. So shall we stop adding text similar to:
> Reviewed-on: https://review.gluster.org/17414
Sometimes I combine 2 commits from master (typically commit 2 which fixes a bug in commit 1) in to a single patch while backporting. The change ID is not the same in that case and I explicitly mention the 2 patch urls in the squashed commit sent to the release branch. So in those cases, some way to trace back to the patches in master is helpful. Otherwise I think it is fair to omit it.Ah! makes sense. Maybe for exceptions, let us use this but as a rule maybe it doesn't seem like a bad idea to omit. Let us also hear from others.
For easier one click approach, I guess, one can keep the 'Reviewed-on:' line with URL. All other info is just extra bytes IMO.
-Amar
> Smoke: Gluster Build System <jenkins@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Pranith Kumar Karampuri <pkarampu@xxxxxxxxxx>
> Tested-by: Pranith Kumar Karampuri <pkarampu@xxxxxxxxxx>
> NetBSD-regression: NetBSD Build System <jenkins@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Amar Tumballi <amarts@xxxxxxxxxx>
> CentOS-regression: Gluster Build System <jenkins@xxxxxxxxxxxxxxxxx>
(cherry picked from commit de92c363c95d16966dbcc9d8763fd4448dd84d13)
in the patches?
Do you see any other value from this information that I might be missing?
--
Pranith
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://lists.gluster.org/mailm an/listinfo/gluster-devel
--Pranith
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://lists.gluster.org/mailman/listinfo/gluster-devel
--
Amar Tumballi (amarts)
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://lists.gluster.org/mailman/listinfo/gluster-devel
